Skip to content

made DanceResponse summarize more shallow to prevent test hangs#398

Merged
evomimic merged 1 commit intomainfrom
397-enhancement-make-danceresponse-logging-shallow-to-prevent-trace-level-test-hangs
Feb 18, 2026
Merged

made DanceResponse summarize more shallow to prevent test hangs#398
evomimic merged 1 commit intomainfrom
397-enhancement-make-danceresponse-logging-shallow-to-prevent-trace-level-test-hangs

Conversation

@owleyeview
Copy link
Collaborator

PR: Make DanceResponse Logging Shallow and Trace-Safe

Summary

This PR updates DanceResponse::summarize() to avoid deep debug traversal of transaction-bound runtime graphs when logging.

After the Phase 1.2 transaction-aware reference refactor, DanceResponse contains tx-bound holon references. Formatting these with {:#?} can traverse:

  • HolonReference
  • TransactionContextHandle
  • Arc<TransactionContext>
  • Pools, staged holons, relationships, etc.

With tracing enabled, this caused severe performance degradation and apparent test hangs as the object graph grew.


What Changed

  • DanceResponse::summarize() now:

    • Avoids formatting full runtime references
    • Avoids traversing TransactionContextHandle
    • Logs only shallow identifiers and counts (e.g. holon IDs, tx_id)
  • No changes to runtime behavior or transaction logic

  • No changes to wire types or binding behavior

This strictly affects logging behavior.


Why This Is Safe

  • No functional logic modified
  • No change to reference semantics
  • No change to transaction provenance
  • Only reduces logging surface depth

Result

  • Tests complete successfully with tracing enabled
  • No more trace-level hangs due to debug graph traversal
  • Logs remain readable and informative
  • Logging cost remains bounded as state grows

Copy link
Owner

@evomimic evomimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made reduce log output to the point where all tests pass. That's good!

Unfortunately, they also make the logs virtually useless to debug any real issues because they reveal nothing about state... just a stream of events.

What this really illustrates is that we've outgrown our logging strategy and a deeper re-factor is in order.

I'm going to approve this PR for now so we can unblock other development tasks. We can open a separate enhancement for re-factoring logging approach.

@evomimic evomimic merged commit 6fa071c into main Feb 18, 2026
2 checks passed
@evomimic evomimic deleted the 397-enhancement-make-danceresponse-logging-shallow-to-prevent-trace-level-test-hangs branch February 18, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] **Make DanceResponse Logging Shallow to Prevent Trace-Level Test Hangs**

2 participants