Conversation
evomimic
approved these changes
Feb 18, 2026
Owner
evomimic
left a comment
There was a problem hiding this comment.
The changes made reduce log output to the point where all tests pass. That's good!
Unfortunately, they also make the logs virtually useless to debug any real issues because they reveal nothing about state... just a stream of events.
What this really illustrates is that we've outgrown our logging strategy and a deeper re-factor is in order.
I'm going to approve this PR for now so we can unblock other development tasks. We can open a separate enhancement for re-factoring logging approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Make
DanceResponseLogging Shallow and Trace-SafeSummary
This PR updates
DanceResponse::summarize()to avoid deep debug traversal of transaction-bound runtime graphs when logging.After the Phase 1.2 transaction-aware reference refactor,
DanceResponsecontains tx-bound holon references. Formatting these with{:#?}can traverse:HolonReferenceTransactionContextHandleArc<TransactionContext>With tracing enabled, this caused severe performance degradation and apparent test hangs as the object graph grew.
What Changed
DanceResponse::summarize()now:TransactionContextHandleNo changes to runtime behavior or transaction logic
No changes to wire types or binding behavior
This strictly affects logging behavior.
Why This Is Safe
Result