Conversation
9 tasks
684a851 to
aa5fd97
Compare
evomimic
requested changes
Mar 2, 2026
shared_crates/holons_core/src/core_shared_objects/transactions/transaction_context.rs
Outdated
Show resolved
Hide resolved
shared_crates/holons_core/src/core_shared_objects/transactions/transaction_context.rs
Show resolved
Hide resolved
shared_crates/holons_core/src/core_shared_objects/transactions/transaction_manager.rs
Outdated
Show resolved
Hide resolved
shared_crates/holons_core/src/core_shared_objects/transactions/transaction_context.rs
Show resolved
Hide resolved
… in tx manager tests
Owner
Final Pre-Merge NoteThis PR is merge-ready for Phase 1.4 scope as currently defined. What’s now in place:
Known intentional follow-up (post-merge):
Given current DoD and clarification boundaries, this PR should be safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the core of Phase 1.4 by consolidating transaction-scoped execution on TransactionContext and removing the legacy context/operations abstractions.
The changes:
HolonsContextBehaviorand context-routed execution paths.HolonOperationsApiand migrate its execution functions ontoTransactionContext+ facades.transaction.mutation()transaction.lookup()TransactionContext(tx_id,state,is_open,commit).open_new_transaction(...)open_transaction_with_id(...)Why
After Phase 1.2/1.3, references and lifecycle were already transaction-centered, but execution still leaked through legacy traits/free functions. This PR removes that split and aligns
execution semantics with the architecture for upcoming MAP Commands and TS SDK work.
Key Implementation Notes
TransactionContextnow exposesmutation()andlookup()and serves as the authoritative transaction-scoped execution root.TransactionContextand applied across mutation operations (exceptnew_holon, per current lifecycle policy).key_from_property_mapsummarize_holonsinto
holon_utils.Scope / Impact
TransactionContext+ facades.Known Follow-up / Remaining Debt
Manager internalization is not fully complete yet:
TransactionContextstill exposes manager-adjacent methods (for examplenursery()and some service accessors), and guest init still has manager-level coupling.TransactionContextmanager visibility in a subsequent issue(this is currently under review).