Add fissionable check to pointwise XS lookups #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the main branch of OpenMC, we have a check when performing pointwise XS lookups to just set `fission` and `nu_fission` to zero if `fissionable_` is false. In our offloading branch, this test isn't present. I'm not sure if this can cause issues, or if the underlying nuclide fission/nu_fission data is zero already, but worth adding this in to maintain the same logic.
paulromano
reviewed
Jan 17, 2024
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
I think the intent of that if block was to prevent extra flops/lookups. Technically it's not needed and you could interpolate between the two zeros. Do you have a sense of which would be better performing on GPU?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the main branch of OpenMC, we have a check when performing pointwise XS lookups to just set
fissionandnu_fissionto zero iffissionable_is false. In our offloading branch, this test isn't present. I'm not sure if this can cause issues, or if the underlying nuclide fission/nu_fission data is zero already, but worth adding this in to maintain the same logic.