Skip to content

Add message for Ruby leap exercise analyzer #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kotp merged 1 commit into from
May 23, 2025
Merged

Add message for Ruby leap exercise analyzer #2376

kotp merged 1 commit into from
May 23, 2025

Conversation

@PatrickMcSweeny
Copy link
Contributor

@PatrickMcSweeny PatrickMcSweeny commented May 19, 2025 •
edited
Loading

Closes #2375 and is part of exercism/ruby#1532

@github-actions github-actions bot added track/ruby Ruby track type/analyzer-comments Analyzer comments labels May 19, 2025
BNAndras
BNAndras reviewed May 19, 2025
View reviewed changes
@PatrickMcSweeny PatrickMcSweeny force-pushed the ruby-leap branch 2 times, most recently from 47b70d6 to eaa60a3 Compare May 21, 2025 20:37
@PatrickMcSweeny
Copy link
Contributor Author

PatrickMcSweeny commented May 21, 2025 •
edited
Loading

I updated the message to be "Avoid using Date.leap? from the Standard Library"

@PatrickMcSweeny PatrickMcSweeny force-pushed the ruby-leap branch 3 times, most recently from 538eecf to c0ea60b Compare May 21, 2025 22:37
SleeplessByte
SleeplessByte previously approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and still concise.

kotp
kotp previously approved these changes May 22, 2025
View reviewed changes
kotp
kotp reviewed May 22, 2025
View reviewed changes
@PatrickMcSweeny PatrickMcSweeny dismissed stale reviews from kotp and SleeplessByte via 4c8f924 May 22, 2025 02:27
@PatrickMcSweeny
Copy link
Contributor Author

PatrickMcSweeny commented May 22, 2025

Can this be merged?

@kotp
Copy link
Member

kotp commented May 23, 2025

It can be by my opinion. Remember that @SleeplessByte was active around 15 minutes from now, yesterday, and I want to give him a chance to confirm, as well as @BNAndras . We all work at different hours of the day, so there is the built in delay, but do know that each of us see all of this work, and there are others that have not spoken here, but they are also reviewing and monitoring. Let's make sure that the maintainers have a chance to respond in full.

It will come in shortly, though, I have confidence!

SleeplessByte
SleeplessByte approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go. @BNAndras please merge when you've seen this!

@BNAndras
Copy link
Member

BNAndras commented May 23, 2025

I don’t have write access here. :)

@kotp kotp merged commit 8adcb72 into exercism:main May 23, 2025
1 check passed
@kotp
Copy link
Member

kotp commented May 23, 2025

I don’t have write access here. :)

You have approval state rights though, and that is what I used to get notified. Thanks!

@PatrickMcSweeny PatrickMcSweeny deleted the ruby-leap branch May 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotp kotp kotp approved these changes

@SleeplessByte SleeplessByte SleeplessByte approved these changes

+1 more reviewer

@BNAndras BNAndras BNAndras approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatrickMcSweeny PatrickMcSweeny

Labels

track/ruby Ruby track type/analyzer-comments Analyzer comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add copy for ruby leap exercise analyzer

4 participants

@PatrickMcSweeny @kotp @BNAndras @SleeplessByte