Add mentoring notes for python/guidos-gorgeous-lasagna #2378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
track/python
BethanyG
previously approved these changes
Jun 3, 2025
Member
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
Nice work! Thanks for writing these up.
One niggle: There is a 5th "task", which is adding docstrings to the functions, which we might want to add a sentence on, with ref to PEP257 (and if you wanted to, sample feedback).
But its a niggle, so I am marking this approved, and you can merge or add the comments as you see fit. 😄
BethanyG
approved these changes
Jun 3, 2025
Member
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
Awesome! Thanks for adding docstrings in. Good to merge from my side. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.