Add Elixir comments for Gotta Snatch em All #2387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
track/elixir
jiegillet
reviewed
Sep 27, 2025
Contributor
jiegillet
left a comment
jiegillet
left a comment
There was a problem hiding this comment.
Very nice, thank you.
Like I mentioned on the other PR, I think it's best to emphasize that other solutions may be idiomatic, so I suggested a variation, let me know what you think.
analyzer-comments/elixir/gotta-snatch-em-all/add_card_use_mapset_member_and_put.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/boring_cards_use_mapset_intersection.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/extra_cards_use_mapset_difference_and_size.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/remove_duplicates_use_mapset_new.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/shiny_cards_use_string_starts_with.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/total_cards_use_mapset_union_and_size.md
Outdated
Show resolved
Hide resolved
analyzer-comments/elixir/gotta-snatch-em-all/trade_card_use_mapset_member_put_and_delete.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jie <jie.gillet@gmail.com>
Member
Author
|
The suggestions looked good to me 😁 . I especially liked the addition of the explanation about other idiomatic methods that are available. |
jiegillet
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzer implementation in exercism/elixir#451.