Add support for OSC reset fg, bg, and cursor color. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithr-git
changed the title
carlosfmesilva
left a comment
carlosfmesilva
left a comment
There was a problem hiding this comment.
With the same exact idea, would it be possible to use colon : within the escape sequence?
Author
|
I'm not aware of any ANSI escape sequences that use colons. There are some that accept freeform text, which should already support including colons. Regardless of that, this change is just for adding support for resetting cursor colors, which differ from previously-supported OSC sequences because they don't have a semicolon-separated parameter. That's the only reason this change modifies the escape sequence parsing; any other changes to the parsing should be a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted support for the OSC sequences that reset the foreground, background, and cursor colors to their original values. Please let me know if there's a format you prefer for pull requests; I couldn't find anything about that in the READMEs.