Team E2557 - Specialized Rubrics for different Topic types#226
Draft
Prismly wants to merge 9 commits intoexpertiza:mainfrom
Draft
Team E2557 - Specialized Rubrics for different Topic types#226Prismly wants to merge 9 commits intoexpertiza:mainfrom
Prismly wants to merge 9 commits intoexpertiza:mainfrom
Conversation
These are changes made to accommodate running the project locally, as per the given setup instructions. - Changed puma version to 6.0 in Gemfile - Removed question mark from DATABASE_URL in docker-compose.yml - Changed the config.load_defaults value in config/application.rb to 8.0
Generated by 🚫 Danger |
- Added a new API route to sign_up_topics_controller.rb (rubric_list), which retrieves topics and their rubric as serialized JSON - Added above route to config/routes.rb
- Introduced a model spec file for the SignUpTopic class (currently untested, as our environment has trouble with the permissions for rspec) - Fixed a type mismatch in our migrations; topic_id in assignment_questionnaires should now be correctly assigned "bigint" everywhere
The rspec_helper file used to use only an older rails / rspec-rails fixture path configuration setting. Now, it is used as a fallback, and a new version is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to complete the following user story for Instructors:
Please see the E2557 wiki page for a more detailed writeup of the implementation in this PR, or view the E2513 wiki page for the implementation that preceded this one.
NOTICE: This PR is unfinished (marked as DRAFT) due to complications with environment setup and code conflicts with the team that has delivered the relevant frontend page. As such, it currently contains very little and is primarily here as a placeholder until later in the week. Thank you for your understanding.This PR is now "feature complete" as of Wednesday, 10/29/25. There are still many shortcomings wrt. to this implementation; see our wiki page (link above) for more details.