Skip to content

fix(react-native-branch): Re-init branch session when resumed from background#189

Open
morgan-cromell wants to merge 1 commit intoexpo:mainfrom
morgan-cromell:main
Open

fix(react-native-branch): Re-init branch session when resumed from background#189
morgan-cromell wants to merge 1 commit intoexpo:mainfrom
morgan-cromell:main

Conversation

@morgan-cromell
Copy link

Why

The react-native-branch plugin used the OnCreate lifecycle hook to call RNBranchModule.InitSession. This caused the session to only be initialized on first start of the application and not when switching from foreground to background.

How

According to the official docs you should use the OnStart hook to intialize Branch, but as this does not exists on ReactActivityLifecycleListener onResume was the closest one.

Test Plan

Tried to send an event to branch from react-native with

const event = new BranchEvent('TEST');
event.logEvent();

I used Android studio to monitor network traffic and see that the event is sent to Branch.

Before this fix this stopped working if the app was sent to the background and later resumed.

@jvgeee
Copy link

jvgeee commented Jun 26, 2024

Can this be merged in please?

@iway1
Copy link

iway1 commented Jan 14, 2025

should this be called in both onCreate and onResume?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants