Add before and after props NavigationBar.Title.#419
Add before and after props NavigationBar.Title.#419dantman wants to merge 1 commit intoexpo:masterfrom
before and after props NavigationBar.Title.#419Conversation
This helps insert non-text components before and after title text in the title area. Adding things like icons to the title is impossible when all of NavigationBar.Title’s children are text.
|
Does |
|
@chirag04 Then you have to manually reimplement all the text styles from scratch to get them back, just so you can stick an icon on the end. |
|
The default implementation of header text doesn't do much. it's not a bad idea of override it especially when you have custom need for icons etc. |
|
@chirag04 How do you feel about decoupling the text portion as a separate component from the title container it is in so the app can override / extend them individually? |
|
@dantman pretty sure the styles are pretty simple. anyways, you can just import the component and reuse, why add more props? |
This helps insert non-text components before and after title text in the title area.
Adding things like icons to the title is impossible when all of NavigationBar.Title’s children are text.