Skip to content

docker: move from acr to ghcr #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csegarragonz merged 1 commit into from
Apr 23, 2025
Merged

docker: move from acr to ghcr #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
- name: "Log in to DockerHub"
uses: docker/login-action@v3
with:
registry: faasm.azurecr.io
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
registry: ghcr.io
username: faasm
password: ${{ secrets.GHCR_PAT }}
- name: "Build and push examples-build image"
uses: docker/build-push-action@v4
with:
Expand All @@ -51,4 +51,4 @@ jobs:
EXAMPLES_VERSION=${{ env.EXAMPLES_VERSION }}
PYTHON_VERSION=${{ env.PYTHON_VERSION }}
context: .
tags: faasm.azurecr.io/examples-build:${{ env.EXAMPLES_VERSION }}
tags: ghcr.io/faasm/examples-build:${{ env.EXAMPLES_VERSION }}
5 changes: 1 addition & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,7 @@ jobs:
if: ${{ needs.needs-build.outputs.needs-wasm == 'true' }}
runs-on: ubuntu-latest
container:
image: faasm.azurecr.io/examples-build:0.6.0_0.4.0
credentials:
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
image: ghcr.io/faasm/examples-build:0.6.0_0.4.0
steps:
- name: "Checkout code"
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions docker/build.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ARG CPP_VERSION
ARG EXAMPLES_VERSION
# Base image is not re-built often and tag may lag behind
FROM faasm.azurecr.io/examples-base:0.6.0_0.4.0 AS base
FROM faasm.azurecr.io/cpp-sysroot:${CPP_VERSION:-dead}
FROM ghcr.io/faasm/examples-base:0.6.0_0.4.0 AS base
FROM ghcr.io/faasm/cpp-sysroot:${CPP_VERSION:-dead}

SHELL ["/bin/bash", "-c"]
ENV IN_DOCKER="on"
Expand Down
Loading