Dk/reverb test #32
Open
Dk/reverb test #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2021 02:01
…et but maybe with some tweaking
fab-jul
reviewed
Dec 17, 2021
| return self._buffer.maxlen | ||
|
|
||
| @property | ||
| def frame_size(self): |
Owner
There was a problem hiding this comment.
This is available as clock_signal.num_samples.
| return np.concatenate(output, 0) | ||
|
|
||
|
|
||
| # Question, do we have access to the sampling frequency of the whole mod synt? |
Owner
There was a problem hiding this comment.
this is available as clock_signal.sample_rate (should be renamed :D )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft PR for now
the delay is kind of usable
the "reverb" can get a bit weird especially when limiting is enabled but it's not really a reverb....