Skip to content

Making website dynamic#52

Open
josueJURE wants to merge 38 commits intomainfrom
making-website-dynamic
Open

Making website dynamic#52
josueJURE wants to merge 38 commits intomainfrom
making-website-dynamic

Conversation

@josueJURE
Copy link
Collaborator

Made the website dynamic instead of static. Uncomment the last object, about Wolverine, in the superheroes array to see the index.html, team.html, and contactus.html pages automatically update. To make the website dynamic, I've written more JS and reduced the HTML. Note that the Wolverine image will need resizing or changing. I included it in the object to illustrate how dynamic the website now is.

Also I use display:grid instead ofdisplay:flexon the contactus.htmlpage.

…caught TypeError: Cannot read properties of null (reading 'innerHTML')
@josueJURE
Copy link
Collaborator Author

BTW the superheroes array is in the index.js file

@gitguardian
Copy link

gitguardian bot commented Jul 1, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12338303 Triggered Generic High Entropy Secret c4ec6a8 node_modules/debug/.coveralls.yml View secret
12338303 Triggered Generic High Entropy Secret 23d5c70 node_modules/debug/.coveralls.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant