Remove Metric.data_constructor #4713
Closed
+6
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89748011. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4713 +/- ##
==========================================
- Coverage 96.69% 96.69% -0.01%
==========================================
Files 580 580
Lines 60697 60693 -4
==========================================
- Hits 58692 58687 -5
- Misses 2005 2006 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
force-pushed
the
export-D89748011
branch
from
e34322f to
796800a
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 29, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 29, 2025
Summary: `Metric.data_constructor` is no longer used following D89689313. Changes: * Remove `Metric.data_constructor` class attribute * Change `Metric.has_map_data` from a property into a class attribute based on whether the metric is a MapMetric The longer-term plan is to allow (and eventually require) all metrics to return `MapData`); instead of checking whether the metric has map data, we should add an attribute `step_should_be_modeled` that tells whether that data is relevant for modeling. This will allow for merging `Metric` and `MapMetric` as well as `Data` and `MapData` Reviewed By: lena-kashtelyan Differential Revision: D89748011
|
This pull request has been merged in f0f93e9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is no longer needed following D89689313.
Changes:
Metric.data_constructorclass attributeMetric.has_map_datafrom a property into a class attribute based on whether the metric is a MapMetricThe longer-term plan is to
has_map_datain favor of an attributestep_should_be_modeledMapMetric; these will becomeMetrics withstep_should_be_model=TrueExperiment.lookup_data) to reflect the possibility that a Metric may return MapData yet havestep_should_be_modeled = FalseMapData(by updating cases whereDatais constructed other than by reading it directly from a metric, e.g. by deserializing it)Differential Revision: D89748011