Skip to content

Conversation

@Victor-Jhong
Copy link
Contributor

Summary:

  • Do post-update before sending "apply complete" to UA
  • In the current flow, once the BMC receives "apply complete", it sends "Active" to the MMC and immediately reinitializes MCTP. If this MCTP reinit happens while the MMC is still running its post-update steps, the two operations conflict and can cause the MMC to hang.
  • By executing the post-update steps before sending "apply complete", we ensure the BMC’s MCTP reinit occurs only after post-update is fully completed.

Test Plan:

  • Build code: Pass

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 4, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88337270. (Because this pull request was imported automatically, there will not be any future comments.)

@Victor-Jhong Victor-Jhong force-pushed the minerva-ag/do_post_update_before_sending_apply_complete_to_UA branch from 8f63ed4 to 77cdb4f Compare December 29, 2025 07:51
@facebook-github-bot
Copy link
Contributor

@Victor-Jhong has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants