TomTom roads from Overture transportation tiles#1769
Merged
jenningsanderson merged 8 commits intomainfrom Feb 27, 2026
Merged
Conversation
Load, filter, conflate, and render TomTom-sourced road data from Overture PMTiles transportation theme. This extends the existing buildings pattern to support line geometry (roads/paths). Key changes: - Discover transportation PMTiles URL via STAC catalog - Extract source from `sources[].dataset` field (transportation theme uses different encoding than buildings' `@geometry_source`) - Filter by source to keep only TomTom features - Mode-aware conflation: motorized roads conflate against motorized OSM highways, non-motorized paths against non-motorized ones - Point-sampling algorithm rejects features where >20% of samples are within 10m of a same-mode OSM highway - Map Overture transportation properties to OSM tags (highway, surface, bridge/tunnel, oneway, layer, footway subclass) - Render roads as lines with endpoint vertices in PixiLayerRapid - Add tomtom-roads to default dataset menu (not auto-enabled) - Add en translations for TomTom Roads dataset label/description - 54 tests covering source extraction, line conversion, tag mapping, conflation, and geometry helper functions
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for viewing and accepting TomTom-sourced roads from Overture’s transportation PMTiles, including client-side conflation against existing OSM highways and auto-connecting accepted endpoints to nearby routable OSM ways.
Changes:
- Introduce new
tomtom-roadsRapid dataset backed by Overture transportation tiles, with mode-aware conflation/filtering. - Enhance
actionRapidAcceptFeatureto optionally auto-connect accepted way endpoints using the editor’s spatialTree, including limited tag inheritance forhighway=road. - Update rendering/UX and add unit + browser tests for the new transportation pipeline and auto-connect behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/actions/rapid_accept_feature.test.js | Adds unit tests for endpoint auto-connect, node merge, layer checks, and highway tag inheritance. |
| test/browser/services/OvertureService.test.js | Adds browser tests for transportation source parsing, tag mapping, sampling/conflation behavior, and transport feature filtering. |
| modules/ui/UiRapidInspector.js | Passes editor.tree into actionRapidAcceptFeature so auto-connect can use the current spatial index. |
| modules/services/OvertureService.js | Adds transportation dataset, conflation/filtering, and GeoJSON→OSM line conversion helpers. |
| modules/pixi/PixiLayerRapid.js | Renders Overture roads as lines + endpoint vertices and resolves node coords via the Overture service graph. |
| modules/core/RapidSystem.js | Adds tomtom-roads to default datasets list and ensures TomTom stays Rapid magenta. |
| modules/actions/rapid_accept_feature.js | Adds optional tree parameter and implements endpoint auto-connect + limited tag inheritance. |
| data/l10n/core.en.json | Adds localization strings for the TomTom Roads dataset label/description. |
| data/core.yaml | Adds the same localization strings to the source YAML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to enabling non-OSM sourced Overture transportation data from TomTom to be added into OSM. There are some theoretical edge cases here involving midpoint intersections but Rapid does a good job of detecting issues and helping resolve.
Tested:
From
/#map=17.26/38.62021/27.47057&background=Bing&datasets=ml-buildings-overture,tomtom-roadsrapid_tt_roads_updated.mp4