Fix SortedSet: new_unchecked debug assertion and sorted union #1200
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a debug assertion in `SortedSet::new_unchecked` to ensure the inner OrderedSet is already sorted. - Updated `SortedSet::union` to return a properly sorted `SortedSet` instead of an unsorted iterator. - Ensures that all SortedSet instances maintain the invariant that elements are sorted, improving safety and correctness. This fixes potential issues where unsorted elements could be introduced and guarantees that union operations produce a valid SortedSet.
meta-cla
bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D90589173. (Because this pull request was imported automatically, there will not be any future comments.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortedSet::new_uncheckedto ensure the inner OrderedSet is already sorted.SortedSet::unionto return a properly sortedSortedSetinstead of an unsorted iterator.This fixes potential issues where unsorted elements could be introduced and guarantees that union operations produce a valid SortedSet.