fix(oss): fb303_thrift -> fb303_core #71
Open
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR depends on an upcoming PR to fbthrift, hence the build error. I'll add a link here once that one is created. Apologies for submitting in the wrong order. |
Contributor
Author
|
This PR depends on fbthrift PR 671 which adds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff aligns the OSS target naming with that in the internal BUCK build, enabling fb303 to build with PYTHON_EXTENSIONS enabled as well as clearing the way for other projects which depend on this one.
Additionally, this change enables the "py3" thrift generator to run, which is required by other Meta OSS projects.
Test:
This change has been tested by running a full build of EdenFS in the sapling project, pinned to this revision. (There are other changes to folly, fbthrift, rust-common, as well as sapling necessary to get a green build, but this a step on that path.)