Include globalPrefix with the default getRunModuleStatement#1571
Open
jbroma wants to merge 4 commits intofacebook:mainfrom
Open
Include globalPrefix with the default getRunModuleStatement#1571jbroma wants to merge 4 commits intofacebook:mainfrom
globalPrefix with the default getRunModuleStatement#1571jbroma wants to merge 4 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a followup for #1512 & #1566 we should include the
globalPrefixfor the defaultgetRunModuleStatementto keep them in sync until the opt out is explicit.This prevents a situation where using
globalPrefixwithout changinggetRunModuleStatementwould break the setup since changes from #1512 make theglobalPrefixalways present in therequire.jspolyfill.Note: needs to be merged after #1512
Changelog: [Breaking] Include
globalPrefixin the defaultgetRunModuleStatementTest plan