feat: add custom event handlers for HMRClient#1595
Open
tjzel wants to merge 1 commit intofacebook:mainfrom
Open
feat: add custom event handlers for HMRClient#1595tjzel wants to merge 1 commit intofacebook:mainfrom
tjzel wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently there's no API in JavaScript to listen to HMRClient updates. This is problematic if a library wants to replace modules used on JavaScript runtime different than the one created by React Native.
This PR adds a global array of event handlers,
HMRClientOnUpdate, which is available very early and which every library can access to obtain HMR updates.Changelog: [Feature] add custom event handlers for HMRClient
Test plan
I don't know how you'd test this change in the repo. I applied these changes in Reanimated monorepo and everything worked well.