chore(types): auto-generate types for metro-transform-worker#1610
Closed
nickhudkins wants to merge 1 commit intofacebook:mainfrom
Closed
chore(types): auto-generate types for metro-transform-worker#1610nickhudkins wants to merge 1 commit intofacebook:mainfrom
nickhudkins wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
Contributor
|
changed the changelog to "internal" before landing this. |
Contributor
nickhudkins
added a commit
to nickhudkins/metro
that referenced
this pull request
Nov 13, 2025
…k#1610) Summary: As I began working to hand-fix some types, the formidable robhogan [pointed me](facebook#1608 (comment)) in the direction of `generateTypeScriptDefinitions.js`, which has been used here to generate types for `metro-transform-worker` Changelog: [Internal]: Auto generate types for `metro-transform-worker` Pull Request resolved: facebook#1610 Test Plan: Automatically tested in CI, also peformed a good-ol eyeball check. Reviewed By: motiz88, robhogan Differential Revision: D86662805 Pulled By: vzaidman fbshipit-source-id: 2e8cc43863b5285976a0759e0c1881b202e1aebc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As I began working to hand-fix some types, the formidable @robhogan pointed me in the direction of
generateTypeScriptDefinitions.js, which has been used here to generate types formetro-transform-workerChangelog: [Internal]: Auto generate types for
metro-transform-workerTest plan
Automatically tested in CI, also peformed a good-ol eyeball check.