Fix TypeScript examples to use InputConfigT instead of ConfigT#1632
Fix TypeScript examples to use InputConfigT instead of ConfigT#1632
Conversation
|
Hi @Copilot! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
…deprecation Co-authored-by: robhogan <2590098+robhogan@users.noreply.github.com>
docs/Configuration.md
Outdated
| ### TypeScript Example (`metro.config.ts`) | ||
|
|
||
| ```typescript | ||
| import type {ConfigT} from 'metro-config'; |
There was a problem hiding this comment.
Types for input config should be InputConfig - it's not necessary to supply a hydrated ConfigT
There was a problem hiding this comment.
Fixed in 9ac5390. Changed both TypeScript examples to use InputConfigT for user config objects and ConfigT for the hydrated config passed to config functions.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Co-authored-by: robhogan <2590098+robhogan@users.noreply.github.com>
9ac5390 to
5141e0f
Compare
Co-authored-by: robhogan 2590098+robhogan@users.noreply.github.com
Stack created with Sapling. Best reviewed with ReviewStack.