Skip to content

Fix TypeScript examples to use InputConfigT instead of ConfigT#1632

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/update-docs-config-support
Closed

Fix TypeScript examples to use InputConfigT instead of ConfigT#1632
Copilot wants to merge 3 commits intomainfrom
copilot/update-docs-config-support

Conversation

Copy link

Copilot AI commented Dec 21, 2025

@meta-cla
Copy link

meta-cla bot commented Dec 21, 2025

Hi @Copilot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

…deprecation

Co-authored-by: robhogan <2590098+robhogan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update documentation to include typescript and ESM config support Update Configuration docs for TypeScript, ESM support and YAML deprecation Dec 21, 2025
Copilot AI requested a review from robhogan December 21, 2025 19:36
### TypeScript Example (`metro.config.ts`)

```typescript
import type {ConfigT} from 'metro-config';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types for input config should be InputConfig - it's not necessary to supply a hydrated ConfigT

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9ac5390. Changed both TypeScript examples to use InputConfigT for user config objects and ConfigT for the hydrated config passed to config functions.

Copilot AI requested a review from robhogan December 21, 2025 19:41
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 22, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Co-authored-by: robhogan <2590098+robhogan@users.noreply.github.com>
@robhogan robhogan force-pushed the copilot/update-docs-config-support branch from 9ac5390 to 5141e0f Compare December 24, 2025 17:13
@robhogan robhogan changed the title Update Configuration docs for TypeScript, ESM support and YAML deprecation Fix TypeScript examples to use InputConfigT instead of ConfigT Dec 24, 2025
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Dec 24, 2025

@robhogan has imported this pull request. If you are a Meta employee, you can view this in D89770691.

@robhogan robhogan closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants