feat: add support for including the babel partial config to cache key#1638
Open
EvanBacon wants to merge 1 commit intofacebook:mainfrom
Open
feat: add support for including the babel partial config to cache key#1638EvanBacon wants to merge 1 commit intofacebook:mainfrom
EvanBacon wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Update the Metro Babel transformer to generate cache keys that include the contents of user Babel configuration files, ensuring cache invalidation when Babel configs change.
EvanBacon
force-pushed
the
@evanbacon/transformer/add-babel-partial-config
branch
from
de0439b to
4f84860
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Metro Babel transformer to generate cache keys that include the contents of user Babel configuration files, ensuring cache invalidation when Babel configs change. This is similar to what Jest does and it seems to work really well for them.
Changelog: [Fix] Include user-defined babel config in transformer cache key to ensure correctness
Test plan