metro-file-map: Don't emit directory events from watcher backends#1646
Open
metro-file-map: Don't emit directory events from watcher backends#1646
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
) Summary: We currently ignore all directory events downstream, so we can simplify the responsibilities of file watcher backends by not emitting directory events. This is part of a refactoring where eventually we *do* want to emit consistent directory events, but we can have greater confidence by doing so only when in-memory "directories" (`Map`s ) are allocated/deleted in the in-memory filesystem. Changelog: Internal Differential Revision: D92053177
facebook-github-bot
force-pushed
the
export-D92053177
branch
from
9d3a914 to
9e31995
Compare
) Summary: We currently ignore all directory events downstream, so we can simplify the responsibilities of file watcher backends by not emitting directory events. This is part of a refactoring where eventually we *do* want to emit consistent directory events, but we can have greater confidence by doing so only when in-memory "directories" (`Map`s ) are allocated/deleted in the in-memory filesystem. Changelog: Internal Differential Revision: D92053177
facebook-github-bot
force-pushed
the
export-D92053177
branch
from
9e31995 to
26b1204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We currently ignore all directory events downstream, so we can simplify the responsibilities of file watcher backends by not emitting directory events.
This is part of a refactoring where eventually we do want to emit consistent directory events, but we can have greater confidence by doing so only when in-memory "directories" (
Maps ) are allocated/deleted in the in-memory filesystem.Changelog: Internal
Differential Revision: D92053177