Auto-build emhermesc.js with GitHub Action#796
Closed
robhogan wants to merge 4 commits intofacebook:mainfrom
Closed
Auto-build emhermesc.js with GitHub Action#796robhogan wants to merge 4 commits intofacebook:mainfrom
emhermesc.js with GitHub Action#796robhogan wants to merge 4 commits intofacebook:mainfrom
Conversation
Contributor
|
@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
Closing this for now as there's some more work to do to find a nice workflow - it seems that we can't commit to forks from an action even when the PR author allows commits from maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
emhermesc.jswas built from.Change
See the diff on the Readme (TL;DR - this uses a GitHub action to perform the build based on
hermes-github-ref, and auto-pushes to a PR / uploads the result / fails on a mismatch).Test plan
I iterated this on my fork: https://github.com/rh389/metro
Job fails because the file is out of sync on main
https://github.com/rh389/metro/runs/5662424803?check_suite_focus=true

Job succeeds by pushing to a PR
robhogan#3

Artifacts are uploaded