Split up SignedConstantDomain and other cleanups #968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 12, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
2 times, most recently
from
a46a467 to
0cd6233
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 12, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
0cd6233 to
b38cb28
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 13, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
b38cb28 to
bbaae71
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 13, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 13, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
bbaae71 to
3213b40
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 13, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
3213b40 to
f33c95a
Compare
xuhdev
added a commit
to xuhdev/redex
that referenced
this pull request
Nov 13, 2025
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
f33c95a to
a077d31
Compare
Summary: The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later). Additionally, moved some big function definitions out of the class for better readability. Added and used `Bounds::from_range`. This is a no-op diff. Differential Revision: D86894728
xuhdev
force-pushed
the
export-D86894728
branch
from
a077d31 to
545c6bc
Compare
|
This pull request has been merged in 9ce8644. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The class is now doing too many things. Split up for better testability and easier implementation for future optimizations. Put internal implementations under an internal namespace rather than nested (easier to test some logically complicated part as individual components later).
Additionally, moved some big function definitions out of the class for better readability. Added and used
Bounds::from_range.This is a no-op diff.
Differential Revision: D86894728