Skip to content

Apply pull_request_template.md when creating pull requests #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rejc2 wants to merge 1 commit into from
Closed

Apply pull_request_template.md when creating pull requests #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions eden/scm/sapling/ext/github/submit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,23 @@ async def create_serial_strategy_params(
return SerialStrategyParams(refs_to_update, pull_requests_to_create, repository)


def get_pull_request_template(commit: CommitData) -> None | str:
change_context = commit.ctx
for path in [
".github/pull_request_template.md",
"docs/pull_request_template.md",
"pull_request_template.md",
]:
try:
file_context = change_context.filectx(path)
bytes = file_context.data()
return str(bytes, "utf-8")
except:
pass # Ignore error when file is not found

return None


async def create_pull_requests_serially(
commits: List[Tuple[CommitData, str]],
workflow: SubmitWorkflow,
Expand Down Expand Up @@ -450,6 +467,8 @@ async def create_pull_requests_serially(

commit_msg = commit.get_msg()
title, body = title_and_body(commit_msg)
pull_request_template = get_pull_request_template(commit)
body = "\n\n".join(filter(None, [body, pull_request_template]))
result = await gh_submit.create_pull_request(
hostname=repository.hostname,
owner=owner,
Expand Down