This repository was archived by the owner on Sep 26, 2018. It is now read-only.
Broadcast SMS - client implementation#78
Open
shivkumarsah wants to merge 2 commits intofacebookarchive:masterfrom
Open
Broadcast SMS - client implementation#78shivkumarsah wants to merge 2 commits intofacebookarchive:masterfrom
shivkumarsah wants to merge 2 commits intofacebookarchive:masterfrom
Conversation
|
@shivkumarsah has updated the pull request. View: changes |
shaddi
suggested changes
May 22, 2018
Contributor
shaddi
left a comment
shaddi
left a comment
There was a problem hiding this comment.
This implements sending a batch of unicast SMS to all registered subscribers, not bulk SMS. This can cause issues with congestion, particularly given subscribers in the subscriber database may not be present on the particular BTS. Let's implement a code path for actual SMS if the underlying GSM stack supports it instead.
| self._send_raw_to_freeswitch_cli( | ||
| str("python VBTS_Send_SMS %s|%s|%s" % ( | ||
| to, from_, body))) | ||
| return True |
Contributor
There was a problem hiding this comment.
Why do we assume True? What if the send fails for some reason?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review sms broadcast client implementation which include the below features:-