This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Update dependency versions#52
Open
scottfranklin wants to merge 2 commits intofacebookarchive:masterfrom
Open
Conversation
Summary: Pull in the latest changes from various dependencies. - Update FB dependencies to a newer date - Use a commit hash for wangle, since its version tagging seems to have failed this week - Update to the latest zstd version Test Plan: - It builds - Tests pass
|
@scottfranklin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mlgood
suggested changes
Aug 1, 2017
Contributor
mlgood
left a comment
mlgood
left a comment
There was a problem hiding this comment.
Seems to have broken CircleCI -- can you taken another pass?
|
@scottfranklin updated the pull request - view changes - changes since last import |
Contributor
Author
|
Trying CircleCI again with a patched fbthrift Makefile. I'll send another PR there if this works. |
Contributor
|
So ... this looks to me like it fixes the problem at hand, even though the check failed. This is because the build looks like it launched beringei (instead of just building it). We should fix that, but it seems like a different change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pull in the latest changes from various dependencies.
failed this week
Test Plan: