Conversation
|
Hi @mengxn! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| public void startShimmer(Animator.AnimatorListener listener) { | ||
| if (mValueAnimator != null && !isShimmerStarted() && getCallback() != null) { | ||
| if (listener != null) { | ||
| mValueAnimator.addListener(listener); |
There was a problem hiding this comment.
You're adding a listener here but never removing it, you should also removeAllListeners on line 171
There was a problem hiding this comment.
Also should be removed in stopShimmer, otherwise starting and stopping will constantly accumulate new listeners
4 participants
listen animation state