This repository was archived by the owner on Sep 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Postprocessor Improvement #75
Open
lh5844
wants to merge
14
commits into
facebookresearch:main
Choose a base branch
from
lh5844:postprocess
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detokenizer agent
…us/next text segments
annasun28
reviewed
Sep 6, 2023
Contributor
annasun28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this makes sense, thanks Lucy! Could you add the test command you used and the outputs produced to your commit summary?
| second_half = prediction_list[0] | ||
| complete_word = first_half + second_half | ||
| self.prediction_list.pop() | ||
| self.delays.pop() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also pop the last from self.elapsed? It's similar to self.delays except that it also includes the actual inference time
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! I have made those changes now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue of the sentence piece model not correcting when two words should be together. For example, if there were two text segments with the first one ending in "with" and the second one beginning with "out", the model would identify it as two different words. However, we want the two to be together as "without", and this would involve correcting the prediction list, delays list, and elapsed list for latency accuracy.
To run the spm_detokenizer_agent.py, use this command in the
SimulEvaldirectory:simuleval \ --user-dir examples \ --agent-class examples.quick_start.spm_detokenizer_agent.DummyPipeline \ --source examples/quick_start/spm_source.txt \ --target examples/quick_start/spm_target.txt \ --output tmp_output \ --segment-k 3 \ --sentencepiece-model examples/quick_start/tokenizer.model \ --detokenize-onlyThis is the expected output for