Add GitHub Actions CI with GPU testing infrastructure#8
Open
robtaylor wants to merge 3 commits intofacebookresearch:mainfrom
Open
Add GitHub Actions CI with GPU testing infrastructure#8robtaylor wants to merge 3 commits intofacebookresearch:mainfrom
robtaylor wants to merge 3 commits intofacebookresearch:mainfrom
Conversation
Implements Apple Metal support as an additional backend alongside CPU and CUDA: - MetalDefs.h/mm: Buffer registry, context management, and MetalMirror helper - MetalKernels.metal: Compute shaders for factorization and solve operations - MatOpsMetal.mm: NumericCtx and SolveCtx implementations using Metal + Eigen - MetalFactorTest.cpp, MetalSolveTest.cpp: Test suites for factor and solve ops Key implementation details: - Float-only (Apple Silicon lacks double precision support) - Uses Eigen for dense operations (potrf, trsm, saveSyrkGemm) - Metal compute kernels for sparse operations (factor_lumps, sparse_elim, assemble) - MTLResourceStorageModeShared for CPU/GPU data sharing - Row-major storage for Eigen compatibility All 8 Metal tests pass (factor, solve with sparse elimination + dense factorization). All 89 CPU tests continue to pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add OpenCL/CLBlast backend as portable GPU fallback: - Add BASPACHO_USE_OPENCL CMake option with CLBlast dependency - Add FindCLBlast.cmake module - Add BackendOpenCL to BackendType enum - Update detectBestBackend() priority: CUDA > Metal > OpenCL > CPU - Create OpenCLDefs.h/cpp with context management and buffer mirroring - Port sparse kernels to OpenCL (factor_lumps, assemble, solve kernels) - Create MatOpsOpenCL.cpp with NumericCtx/SolveCtx stubs - CPU fallback for potrf (CLBlast doesn't have this) - CLBlast ready for trsm/gemm (CPU fallback for now) This is a foundational commit - OpenCL backend compiles but operations throw "not yet implemented" for full GPU execution. CPU-only build verified: 89 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add Metal backend solver to benchmark suite (Bench.cpp) - Uses float precision (Metal hardware limitation) - Supports factor and solve operations with timing - Create GitHub Actions workflow (macos-metal.yml) - Runs on macos-14 runner (Apple Silicon M1/M2) - Two jobs: build-and-test, benchmark - Runs all CPU and Metal tests - Executes benchmarks comparing Metal vs CPU BLAS - Uploads benchmark results as artifacts - Posts summary to GitHub Actions The workflow can be triggered manually with custom parameters: - benchmark_iterations: Number of iterations per problem - problem_filter: Regex to filter specific problems 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Hi @robtaylor! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive CI/CD pipeline for testing all backends:
Workflows
Infrastructure
Features
Dependencies
Please merge those PRs first, then this PR can be rebased cleanly.
Test Plan
🤖 Generated with Claude Code