Define bounds on both circle and rect for use with interfaces#316
Open
bhperry wants to merge 1 commit intofaiface:masterfrom
Open
Define bounds on both circle and rect for use with interfaces#316bhperry wants to merge 1 commit intofaiface:masterfrom
bhperry wants to merge 1 commit intofaiface:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my project I have a basic Shape interface defined as
It would be super useful if the pixel shapes matched this interface. Rect of course would just return itself.
Working on a physics engine built on top of pixel (🤫), and I'm trying to keep to native pixel structs as much as possible. This would give me a lot of flexibility in working with them.
Not sure if it makes sense to add the interface itself to pixel or not, but I would certainly use it.