Skip to content

Remove SETTINGS_WT_MAX_SESSION from h2 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martenrichter merged 2 commits into from
Feb 1, 2026
Merged

Remove SETTINGS_WT_MAX_SESSION from h2 #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a40a18
Remove SETTINGS_WT_MAX_SESSION from h2
martenrichter Feb 1, 2026
11ec10e
1.5.3
martenrichter Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions main/lib/http2/node/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,14 @@ export class Http2WebTransportClient {
settings: {
enableConnectProtocol: true,
customSettings: {
0x2b60: 1, // SETTINGS_WT_MAX_SESSIONS, TODO fix number
0x2b61: this.initialSessionFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_DATA
0x2b62: this.initialStreamFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_STREAM_DATA_UNI
0x2b63: this.initialStreamFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_STREAM_DATA_BIDI
0x2b64: this.initialUnidirectionalStreams, // SETTINGS_WT_INITIAL_MAX_STREAMS_UNI
0x2b65: this.initialBidirectionalStreams // SETTINGS_WT_INITIAL_MAX_STREAMS_BIDI
}
},
remoteCustomSettings: [0x2b60, 0x2b61, 0x2b62, 0x2b63, 0x2b64, 0x2b65],
remoteCustomSettings: [0x2b61, 0x2b62, 0x2b63, 0x2b64, 0x2b65],
localPort: this.localPort,
// TODO: REMOVE BEFORE RELEASE; UNSAFE SETTING
rejectUnauthorized: !this.serverCertificateHashes
Expand Down
3 changes: 1 addition & 2 deletions main/lib/http2/node/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,14 @@ export class Http2WebTransportServer {
settings: {
enableConnectProtocol: true,
customSettings: {
0x2b60: 1, // SETTINGS_WT_MAX_SESSIONS, TODO fix number
0x2b61: this.initialSessionFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_DATA
0x2b62: this.initialStreamFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_STREAM_DATA_UNI
0x2b63: this.initialStreamFlowControlWindow, // SETTINGS_WT_INITIAL_MAX_STREAM_DATA_BIDI
0x2b64: this.initialUnidirectionalStreams, // SETTINGS_WT_INITIAL_MAX_STREAMS_UNI
0x2b65: this.initialBidirectionalStreams // SETTINGS_WT_INITIAL_MAX_STREAMS_BIDI
}
},
remoteCustomSettings: [0x2b60, 0x2b61, 0x2b62, 0x2b63, 0x2b64, 0x2b65]
remoteCustomSettings: [0x2b61, 0x2b62, 0x2b63, 0x2b64, 0x2b65]
})

this.serverInt.on('listening', () => {
Expand Down
2 changes: 1 addition & 1 deletion main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fails-components/webtransport",
"version": "1.5.2",
"version": "1.5.3",
"description": "A component to add webtransport support (server and client) to node.js using libquiche",
"exports": {
".": {
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fails-components/webtransport-workspace",
"version": "1.5.2",
"version": "1.5.3",
"description": "A component to add webtransport support (server and client) to node.js using libquiche",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fails-components/webtransport-tests",
"version": "1.5.2",
"version": "1.5.3",
"description": "An automated test for the webtransport component",
"exports": {
".": {
Expand Down
2 changes: 1 addition & 1 deletion transports/http3-quiche/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@fails-components/webtransport-transport-http3-quiche",
"version": "1.5.2",
"version": "1.5.3",
"description": "A component to add webtransport support (server and client) to node.js, transport using libquiche",
"exports": {
".": {
Expand Down