Open
Conversation
…on check with new methods in utils.py
… port_group apparition'
…n add portgroup with port_id_list (tuple). Remove portgroup before to remove ports
falkTX
force-pushed
the
main
branch
13 times, most recently
from
edcab1c to
903ad4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the portgroups in patchcanvas (GUI only).
Add ports with no portgroup_id information. When all ports are here, engine has to add the portgroup (with the tuple port_id_list). Take care to remove the portgroup before to remove the port (patchcanvas will refuse to remove the port).
You can make a portgroup with port context menu : set as stereo with -> .
You can also remove it with portgroup context menu : split to monos.
You've to find a way to generate and stock portgroup ids.
I haven't put the stereo detection here (based on port names), just ask if you want it. Mine is written in python, but it is of course translatable to c++ if you need it in engine.