Add disconnect-all-of-group menu item to patchbay#1483
Open
sebageek wants to merge 1 commit intofalkTX:mainfrom
Open
Add disconnect-all-of-group menu item to patchbay#1483sebageek wants to merge 1 commit intofalkTX:mainfrom
sebageek wants to merge 1 commit intofalkTX:mainfrom
Conversation
sebageek
force-pushed
the
disconnect-whole-group-menu-item-but-without-lambdas
branch
from
6e4e121 to
9919cc2
Compare
Contributor
Author
|
Rebase to current main + added a separator between the normal entries and the "cut a complete group" entries. |
If one group has multiple connections to another group an extra menu item is added to its disconnect context menu, which allows the user to disconnect it all at once. The entry is added at the bottom of the disconnect menu in the form of "Groupname (all x ports)". This comes in very handy when the user wants to disconnect a soundcard from their current application. PortContextMenuDisconnect() now also accepts a list via setData()/data(), so we can disconnect multiple ports at once.
sebageek
force-pushed
the
disconnect-whole-group-menu-item-but-without-lambdas
branch
from
9919cc2 to
770b5cb
Compare
falkTX
force-pushed
the
main
branch
13 times, most recently
from
edcab1c to
903ad4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one group has multiple connections to another group an extra menu
item is added to its disconnect context menu, which allows the user to
disconnect it all at once. The entry is added at the bottom of the
disconnect menu in the form of "Groupname (all x ports)". This comes in
very handy when the user wants to disconnect a soundcard from their
current application.
PortContextMenuDisconnect() now also accepts a list via
setData()/data(), so we can disconnect multiple ports at once.
Heyhey, first PR on this project, hope this feature is interesting to you!
I'm a bit unsure about how the patchcanvas module is maintained. I know it is at least used in Catia. Would we need to port this change over? Especially as I augment the functionality of
PortContextMenuDisconnect().