You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1
If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet
Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1
If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet
Sounds good, I will update the PR with the rename.
@tritao Could you get the latest changes from master and do the mentioned changes above, so I can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, adds support for Cosmos-based networks.
Tested against the terra.js SDK.