feat(fastrace-opentelemetry): add bridge for current local context#153
Merged
andylokandy merged 3 commits intofast:mainfrom Dec 18, 2025
Merged
feat(fastrace-opentelemetry): add bridge for current local context#153andylokandy merged 3 commits intofast:mainfrom
andylokandy merged 3 commits intofast:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a bridge function to convert fastrace's thread-local parent context into an OpenTelemetry SpanContext, enabling interoperability with OpenTelemetry-based instrumentation. It also includes minor refactoring of variable names in the global collector for improved clarity.
Key changes:
- Introduces
current_opentelemetry_context()function to extract the current fastrace local parent as an OpenTelemetry span context - Refactors variable naming in
global_collector.rsto reduce verbosity and improve scoping - Updates documentation with examples demonstrating the new bridging functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
fastrace/src/collector/global_collector.rs |
Refactored variable names from global_collector to collector for brevity and introduced scoped blocks to improve lock lifecycle management |
fastrace-opentelemetry/src/lib.rs |
Added current_opentelemetry_context() function and renamed SpanContext import to OtelSpanContext to avoid naming conflicts |
fastrace-opentelemetry/tests/context.rs |
Added integration test verifying that OpenTelemetry spans can be correctly parented by fastrace local parent spans |
fastrace-opentelemetry/README.md |
Added new documentation section explaining how to activate OpenTelemetry trace context, fixed typo in "otlp", and updated dependency versions |
fastrace-opentelemetry/Cargo.toml |
Added enable feature to fastrace dev-dependency for testing |
fastrace-opentelemetry/CHANGELOG.md |
Added entry documenting the new helper functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141