Conversation
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup work to improve documentation accuracy and test coverage for the OnceMap and singleflight::Group types. The changes include grammar corrections, test additions, and trait assertion tests.
Changes:
- Fixed grammar error in
OnceMap::discarddocumentation ("remove" → "removed") - Corrected CHANGELOG method name reference (
Group::remove→Group::forget) - Added comprehensive test coverage for
OnceMapandsingleflight::Groupincluding constructors, concurrent operations, and edge cases - Added trait assertions for
Send,Sync, andUnpinforOnceMapandsingleflight::Group
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mea/src/once/once_map/mod.rs | Fixed grammar in documentation comment (spelling correction) |
| CHANGELOG.md | Corrected method name from remove to forget in API change description |
| mea/src/lib.rs | Added trait assertions for OnceMap and singleflight::Group to verify they are Send, Sync, and Unpin |
| mea/src/once/once_map/tests.rs | Added comprehensive tests for constructor methods, concurrent failure handling, removal during computation, and complex key types |
| mea/src/singleflight/tests.rs | Added comprehensive tests for try_work method including simple cases, coalescing, failure handling, and concurrent retry scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.