refactor: migrate project bootstrap to xtask#11
Conversation
|
Hi @tisonkun, thanks again for the previous reviews. I went back to my earlier implementation and tried to address the points you raised back then, simplify some parts of the code, and also incorporate some ideas from the recent Python script you added. I’m not entirely sure if this approach makes sense yet, so for now I’m mainly looking for a quick sanity check. If you have a chance to take a look, I’d really appreciate any feedback. If it looks roughly okay, I can polish it up and make this ready for a proper review. Thanks! |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
fe505f6 to
5214516
Compare
5214516 to
3a13d39
Compare
4f82f04 to
fe8cd8b
Compare
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Updated and merging ...
Thanks for your help! I saw your updates, and the renaming and overriding feel like a much better approach than using features. Learned a lot, thank you! :) |
Draft PR for early feedback on an xtask-based bootstrap implementation.