chore: move mongodb as peer dependency #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
FYI @gurgunday |
jsumners
reviewed
Sep 17, 2024
Member
jsumners
left a comment
jsumners
left a comment
There was a problem hiding this comment.
Thank you, but peer dependencies cause more problems than they solve. We prefer to avoid them.
Author
|
As standard, all plugins use peer dependencies because a specific version can be selected. |
Member
|
In these duplicates, you can find the workaround: fastify/fastify-swagger#220 The decision has been to don't add it as Since npm v10 has been released, we should re-evaluate it: would you like to analyze if it is doable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fastify v5 is released
Checklist
npm run testandnpm run benchmarkand the Code of conduct