fix: Lower the supported NodeJS version from 18 or greater to only 18#485
Merged
JakeChampion merged 2 commits intomainfrom Apr 11, 2023
Merged
fix: Lower the supported NodeJS version from 18 or greater to only 18#485JakeChampion merged 2 commits intomainfrom
JakeChampion merged 2 commits intomainfrom
Conversation
Node 19 is [not supported by tree-sitter yet](tree-sitter/node-tree-sitter#127), and that is a dependency of ours. Until tree-sitter works on Node 19, we should not list Node 19 as supported.
Contributor
|
Hmm, this is a serious issue - can we maybe move to another parser that supports it? Node.js 20 goes out this month and that will be very important to support. |
Contributor
Author
We can probably fork and patch with the linked PR to bring support on for newer Node versions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 19 is not supported by tree-sitter yet, and that is a dependency of ours. Until tree-sitter works on Node 19, we should not list Node 19 as supported.