ng-cancel-drag now works with dynamic child elements#181
Open
sebhofmann wants to merge 1 commit intofatlinesofcode:masterfrom
Open
ng-cancel-drag now works with dynamic child elements#181sebhofmann wants to merge 1 commit intofatlinesofcode:masterfrom
sebhofmann wants to merge 1 commit intofatlinesofcode:masterfrom
Conversation
|
What about this ? Its not merged yet... and I am confirming this as a fix. I have a same problem and I just tested this for dynamic child elements, it works! Can someone pls merge this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a tree like ngDrag > select > option and the options are generated with ng-option, so there is no ways to set the ng-cancel-drag for the options.
If the options have no ng-cancel-drag firefox is buggy when clicking on a option.