Don't fire draggable:end if draggable:start has not been fired#203
Open
cdauth wants to merge 1 commit intofatlinesofcode:masterfrom
Open
Don't fire draggable:end if draggable:start has not been fired#203cdauth wants to merge 1 commit intofatlinesofcode:masterfrom
cdauth wants to merge 1 commit intofatlinesofcode:masterfrom
Conversation
|
I just bump again this PR, because it helps me too, with Chromium 47 on laptop. When I first drag the element, all is fine. Then, if I do a simple click on it, without any dragging, the drag-end event is called. This PR resolve this case too. Thanks in advance for merging! |
|
Any reason why this has not been incorporated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draggable:startis fired when the first mousemove happens after mousedown. Currently,draggable:endis fired on mouseup, regardless if there has been a mousemove. Thus, when clicking a draggable element (without moving the mouse between mousedown and mouseup),draggable:endis fired withoutdraggable:starthaving been fired.This has the effect that
ng-drag-successis executed on the draggable element as if it had been successfully dropped somewhere, but in fact no droppable element will executeng-drop-success, as droppable elements only start checking whether anythingisTouchingthem after adraggable:startevent.In my case I am moving an element, so one is removed on
ng-drag-successand another one is created onng-drop-success. When clicking the element, it is removed.