Namespaced binding handlers#26
Open
mdarens wants to merge 1 commit intofaulknercs:masterfrom
mdarens:namespace-binding-handlers
Open
Namespaced binding handlers#26mdarens wants to merge 1 commit intofaulknercs:masterfrom mdarens:namespace-binding-handlers
mdarens wants to merge 1 commit intofaulknercs:masterfrom
mdarens:namespace-binding-handlers
Conversation
Owner
|
Thanks for contributing, I think, it is a good idea, will try to do something with this. |
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning!
Thanks for writing these sweet bindings. I made a branch to get them working in projects at work (colliding with some other binding handlers, which also need to be namespaced).
I realize this would be a big breaking change and don't necessarily expect this to be merged as is, or ever, but thought you might find it useful to see what I changed.
Possible improvement: make the namespace configurable, perhaps triggering the registration of bindings manually as one does with
knockout.punches