Open
Conversation
ptpaterson
force-pushed
the
client-container
branch
from
4e34ec0 to
4edb083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-###
Problem
Some but not all exports from
/lib/fauna-client.mjsare in the container as individual values, so we have several files that import some thing directly from "fauna-client", but other things by resolving the containerized values.We include
formatErroras a containerized and mocked function, but it's not used.Solution
containers the "fauna-client" module as a single item and mock the fields that are necessary.
Result
No functional changes.
Using functions from "fauna-client" module always come from the container.
I think this is more maintainable. It would have been more straightforward to add tests for
formatQueryInfoif "fauna-client" was already treated as a containerized module.Testing
Updated tests to work with new container value.