Conversation
- remove unused inquirer dependency (all our usages of inquirer use the newer, non-deprecated @inquirer/prompts package). - move @shikijs/cli and eslint to dev dependencies instead of runtime dependencies.
jrodewig
reviewed
Feb 11, 2025
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
The changeset looks good to me. I left some feedback, but most of it is nit-like. Feel free to ignore as desired.
Co-authored-by: James Rodewig <james.rodewig@fauna.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We would like to automate releases.
Solution
Draft a GitHub action to do this.
Result
We have a draft version of a GitHub action to automate releases.
Testing
Trying to set this up with a dry run mode. Once we're happy with how it looks we can merge this and run a dry run.