modify the extract representation to support various types of inputs#24
Open
fym0503 wants to merge 1 commit intofdalvi:masterfrom
Open
modify the extract representation to support various types of inputs#24fym0503 wants to merge 1 commit intofdalvi:masterfrom
fym0503 wants to merge 1 commit intofdalvi:masterfrom
Conversation
fdalvi
requested changes
Jun 7, 2022
Owner
fdalvi
left a comment
fdalvi
left a comment
There was a problem hiding this comment.
Looks good Yimin, thanks for starting the PR. I would suggest making your changes in a separate branch in your own repo, i.e. something like fym0503:feat/new_input_type, so that you can update your master branch with the latest changes easily.
| yield line.strip() | ||
| return | ||
| else: | ||
| if isinstance(input_corpus_path,str): |
Owner
There was a problem hiding this comment.
when is this condition used? do we expect the user to pass a single "sentence" as the input corpus?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.