Open
Conversation
fdalvi
reviewed
Aug 30, 2023
Owner
fdalvi
left a comment
fdalvi
left a comment
There was a problem hiding this comment.
Looks really good for a start; I think we can do a few more things:
- Add tests for multiclass (where supported) - including class specific rankings
- Add tests for regression (for linear probe)
- Add more "random" data per test type (vary number of samples, number of neurons), something like 10 for the each configuration (perhaps generated using different seeds) - just to cover more space
- You also need to add syupy under test dependencies in the setup + commit the snapshots folder
- I'm wondering if we should make it clear somewhere (in the filename, top level comment or test names) that these are regression tests; maybe not that important
| import torch | ||
|
|
||
| seed_value = 99 | ||
| np.random.seed(seed_value) |
Owner
There was a problem hiding this comment.
We should set a few other seeds, torch's/python's random to ensure the same env everytime
Owner
|
@baselmousi Whats v1 and v2 here? Are these testing for different things? We can name them better in that case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added regression tests for testing the rankings obtained. used syrupy to implement the snapshot testing.