Open
Conversation
Owner
|
Hey @cannoneyed thanks for the PR. I'm unable to support this project in a professional capacity, so I am wondering if you would like to become a collaborator to get this project in a state that is hopefully usable for yourself and others? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, RenderMan is configured to render random synth patches - this PR adds in a few methods to load a preset file and set the parameters of the VST plugin from that preset, as well as setting parameters manually.
In order to make things a little more compatible with the previous API, I've simply added an
overridePatchparameter to therenderPatchmethod, which allows for the user to call the method with either the manually applied parameter settings or the random "override" patch.A better API would be to have two separate methods -
renderPatch(which simply renders audio) andsetRandomPatchthat splits random patch generation away from rendering. I'd be happy to make these changes if this feels like a reasonable direction.